Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger データに不整合がある場合でもエラーが発生しないように修正 #54

Merged
merged 1 commit into from
Jul 28, 2020
Merged

trigger データに不整合がある場合でもエラーが発生しないように修正 #54

merged 1 commit into from
Jul 28, 2020

Conversation

okazy
Copy link
Contributor

@okazy okazy commented Jul 28, 2020

ジェネレータでデータ作成時に $entity->getProductClass() が未設定でflushされることがあり、イベントが発生してエラーが発生していたのでnullのチェックを追加した。

@okazy okazy added the bug Something isn't working label Jul 28, 2020
@okazy okazy added this to the 1.0 milestone Jul 28, 2020
@okazy okazy mentioned this pull request Jul 28, 2020
Merged
@kiy0taka kiy0taka merged commit 63d223d into EC-CUBE:master Jul 28, 2020
@okazy okazy mentioned this pull request Jul 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@okazy @kiy0taka